Improve test coverage and Node environment by ccombe · Pull Request #19 · ccombe/emom-timer

ccombe · 2026-02-27T23:40:19Z

Silenced noisy test output and increased overall coverage to 90.5%. Set up .nvmrc for Node v24 LTS latest (Krypton) and configured Git auto-upstream.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a4cb18fcf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/ts/storage.test.ts

package.json

Copilot

Pull request overview

This PR focuses on expanding Vitest coverage around core logic, storage, and Google Fit integration while also tightening the project’s Node/tooling configuration (Node version, pnpm/lockfile updates, and a Rollup override).

Changes:

Added/expanded unit tests for StorageService, core timer logic edge cases, and GoogleFitService behaviors (token expiry, init/connect, error paths).
Updated Node/tooling configuration via package.json engines and pnpm lockfile changes (including a Rollup override).
Added an .nvmrc to guide local Node selection.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/ts/storage.test.ts	Adds settings persistence tests (but currently introduces an order-dependent/flaky test).
src/ts/logic.test.ts	Adds edge-case tests for `getCurrentRound` and `getCountdownBeep`.
src/ts/google-fit.test.ts	Adds constructor/init/connect/error-path coverage and reduces noisy stderr in some tests.
pnpm-workspace.yaml	Introduces a Rollup override configuration.
pnpm-lock.yaml	Updates lockfile to reflect overrides and dependency changes.
package.json	Adds Node engine requirement and modifies dependencies.
.nvmrc	Introduces Node major version pinning for local dev.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

package.json

.nvmrc

src/ts/storage.test.ts

src/ts/google-fit.test.ts

ccombe · 2026-02-27T23:55:39Z

@codex review

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pnpm-lock.yaml

.nvmrc

.github/workflows/ci.yml

pnpm-workspace.yaml

package.json

src/ts/google-fit.test.ts

package.json

…endencies

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2bbe10d47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pnpm-lock.yaml

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/ci.yml

src/ts/storage.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-28T00:12:23Z

src/ts/google-fit.test.ts

+            const newService = new GoogleFitService();
+            expect(newService.accessToken).toBeNull();
+            expect(localStorage.getItem('google_fit_token')).toBeNull();
+            logSpy.mockRestore();


logSpy.mockRestore() (and similar console spies later in this file) is called after assertions; if an assertion throws, the spy won't be restored and can leak into subsequent tests. Prefer wrapping the spy usage in try/finally, or add an afterEach that calls vi.restoreAllMocks() so the original console methods are always restored.

Suggested change

const newService = new GoogleFitService();

expect(newService.accessToken).toBeNull();

expect(localStorage.getItem('google_fit_token')).toBeNull();

logSpy.mockRestore();

try {

const newService = new GoogleFitService();

expect(newService.accessToken).toBeNull();

expect(localStorage.getItem('google_fit_token')).toBeNull();

} finally {

logSpy.mockRestore();

}

Copilot · 2026-02-28T00:12:23Z

package.json

+  "packageManager": "pnpm@10.30.3",
+  "pnpm": {
+    "overrides": {
+      "rollup@>=4.0.0 <4.59.0": ">=4.59.0"


The pnpm override value ">=4.59.0" is open-ended, which can make installs non-reproducible (it may float to newer major versions) and can unexpectedly change behavior in CI/local dev. Consider pinning to a specific version (e.g., 4.59.0) or a bounded range (e.g., ^4.59.0) depending on your upgrade policy.

Suggested change

"rollup@>=4.0.0 <4.59.0": ">=4.59.0"

"rollup@>=4.0.0 <4.59.0": "^4.59.0"

Copilot · 2026-02-28T00:12:24Z

src/ts/storage.test.ts

+        await new Promise((resolve, reject) => {
+            request.onsuccess = resolve;
+            request.onerror = reject;


In this Promise wrapper around indexedDB.deleteDatabase, request.onerror = reject will reject with the raw event rather than the underlying request.error, which makes failures harder to diagnose. Consider rejecting with request.error (or a new Error that includes request.error?.message) so test failures are actionable.

Suggested change

await new Promise((resolve, reject) => {

request.onsuccess = resolve;

request.onerror = reject;

await new Promise<void>((resolve, reject) => {

request.onsuccess = () => {

resolve();

};

request.onerror = () => {

const error = request.error;

if (error) {

reject(error);

} else {

reject(new Error(`IndexedDB deleteDatabase("${DB_NAME}") failed for an unknown reason.`));

}

};

improved tests and coverage, minor version bumps of packages

4a4cb18

Copilot AI review requested due to automatic review settings February 27, 2026 23:40

ccombe self-assigned this Feb 27, 2026

Copilot started reviewing on behalf of ccombe February 27, 2026 23:40 View session

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

src/ts/storage.test.ts Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

chore: update CI to Node v24 and pnpm v10

313699e

Copilot AI reviewed Feb 27, 2026

View reviewed changes

chore: address PR review feedback and fix test flakiness

b2bbe10

ccombe requested a review from Copilot February 27, 2026 23:53

Copilot started reviewing on behalf of ccombe February 27, 2026 23:53 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

chore: address PR review feedback, fix test flakiness, and update dep…

4493d4d

…endencies

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

pnpm-lock.yaml Outdated Show resolved Hide resolved

test: refine window.google restoration in tests

95cc4e2

Copilot AI review requested due to automatic review settings February 28, 2026 00:02

Copilot started reviewing on behalf of ccombe February 28, 2026 00:02 View session

chore: fix CI pnpm mismatch and consolidate workspace config

30008ba

Copilot AI reviewed Feb 28, 2026

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

src/ts/storage.test.ts Outdated Show resolved Hide resolved

src/ts/storage.test.ts Outdated Show resolved Hide resolved

Update src/ts/storage.test.ts

cf4fde1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 28, 2026 00:07

Update src/ts/storage.test.ts

a7d4c94

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of ccombe February 28, 2026 00:08 View session

chore(ci): use corepack to honor packageManager pnpm version

24e5949

ccombe merged commit 0ce062d into master Feb 28, 2026
4 checks passed

Copilot AI reviewed Feb 28, 2026

View reviewed changes

	"rollup@>=4.0.0 <4.59.0": ">=4.59.0"
	"rollup@>=4.0.0 <4.59.0": "^4.59.0"

-        await new Promise((resolve, reject) => {
-            request.onsuccess = resolve;
-            request.onerror = reject;
+        await new Promise<void>((resolve, reject) => {
+            request.onsuccess = () => {
+                resolve();
+            };
+            request.onerror = () => {
+                const error = request.error;
+                if (error) {
+                    reject(error);
+                } else {
+                    reject(new Error(`IndexedDB deleteDatabase("${DB_NAME}") failed for an unknown reason.`));
+                }
+            };

Conversation

ccombe commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccombe commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ccombe commented Feb 27, 2026 •

edited

Loading