Add GitHub Action to merge schema files with markdown descriptions#1603
Add GitHub Action to merge schema files with markdown descriptions#1603SFJohnson24 merged 46 commits intomainfrom
Conversation
…descriptions Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
… behavior Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
|
@copilot the base branch has been updated so that the schema and md files relevant to this pr have been moved to the |
…merged/ Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
Updated! The script now processes files from Changes made in commit 9eb5c02:
Verified: 10 schema files processed with 150+ markdown descriptions added successfully. |
|
@copilot The linting and unit tests are still failing. |
Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
Fixed all issues in commit c5b389b: Linting: Resolved flake8 errors in test file:
Unit test: Fixed test expectation to match actual markdown format with blank line after heading CodeQL: No security alerts found All checks should now pass. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot linting is fixed, but black formatting issues still remain |
Co-authored-by: gerrycampion <85252124+gerrycampion@users.noreply.github.com>
There was a problem hiding this comment.
The two schemas are identical in their functional content: defs, operation/operator json match, root level properties, required, if/then, additionalproperties, $id, $schema, markdowndescriptions.
@copilot The only issue I have with this PR is the removal of prettier from the pre-commit config. It seems this was maybe done as prettier is run across the schema but prettier within the config is run across our entire codebase on commits
|
@copilot can you address my comment in the review |
Co-authored-by: SFJohnson24 <96841389+SFJohnson24@users.noreply.github.com>
Good catch! I've restored prettier to the pre-commit config in commit 08a6ded. You're correct that prettier should remain in pre-commit for local development across the entire codebase, while the CI workflow checks only changed files. Both approaches now work together.
Addressed in commit 08a6ded - prettier has been restored to .pre-commit-config.yaml. |
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.