Confetti falls within the container#12
Open
JackThomson2 wants to merge 2 commits intocdvntr:masterfrom
Open
Conversation
Author
|
Also fixed a warning about setting state if the component is unmounted while animating |
|
tried both master and this branch and I am unable to get anything except an empty view to show confetti. Am I doing something wrong or is this not made to nest children within the view? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The confetti will fall within it's container rather than full screen. Useful if you wish to show within a nested view. You can animate over the full screen as well if it is wrapped in a full screen container