Add type annotation and require kwargs for centered_image#13
Merged
sethrj merged 3 commits intoceleritas-project:mainfrom Feb 9, 2026
Merged
Add type annotation and require kwargs for centered_image#13sethrj merged 3 commits intoceleritas-project:mainfrom
sethrj merged 3 commits intoceleritas-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates centered_image in celerpy.visualize to add typing, enforce keyword-only arguments (partially), and tighten width parsing/validation for more predictable image specification construction.
Changes:
- Added
numpy.typing.ArrayLikeand annotatedcenter,xdir, andoutdiraccordingly. - Made
width,xdir, andoutdirkeyword-only and added defaults for the direction vectors/center. - Hardened
widthhandling by accepting scalar numeric widths or validating array-like widths to be shape(2,).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.