Skip to content

Update orange IO models for infix construction#15

Merged
sethrj merged 3 commits intoceleritas-project:mainfrom
sethrj:infix-construction
Feb 10, 2026
Merged

Update orange IO models for infix construction#15
sethrj merged 3 commits intoceleritas-project:mainfrom
sethrj:infix-construction

Conversation

@sethrj
Copy link
Member

@sethrj sethrj commented Feb 9, 2026

Copilot AI review requested due to automatic review settings February 9, 2026 18:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Python JSON I/O models for ORANGE geometry to support infix logic construction and newer ORANGE import/conversion option structures (per #2239).

Changes:

  • Add LogicNotation enum for postfix/infix selection.
  • Refactor ORANGE geometry input options into OrangeGeoFromCsg and OrangeGeoFromGeant with new/renamed fields.
  • Extend ORANGE output schema with tracking_logic and update imports/exports accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
celerpy/model/types.py Adds LogicNotation enum used by ORANGE input/output models.
celerpy/model/input.py Replaces old ORANGE conversion options model with new CSG/Geant import option models and adds infix-related options.
celerpy/model/output.py Adds tracking_logic to ORANGE params output and imports the new enum.
celerpy/model/__init__.py Updates package-level re-exports to the renamed ORANGE input model.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sethrj sethrj merged commit 4f786c6 into celeritas-project:main Feb 10, 2026
7 checks passed
@sethrj sethrj deleted the infix-construction branch February 10, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant