Update orange IO models for infix construction#15
Merged
sethrj merged 3 commits intoceleritas-project:mainfrom Feb 10, 2026
Merged
Update orange IO models for infix construction#15sethrj merged 3 commits intoceleritas-project:mainfrom
sethrj merged 3 commits intoceleritas-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Python JSON I/O models for ORANGE geometry to support infix logic construction and newer ORANGE import/conversion option structures (per #2239).
Changes:
- Add
LogicNotationenum for postfix/infix selection. - Refactor ORANGE geometry input options into
OrangeGeoFromCsgandOrangeGeoFromGeantwith new/renamed fields. - Extend ORANGE output schema with
tracking_logicand update imports/exports accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
celerpy/model/types.py |
Adds LogicNotation enum used by ORANGE input/output models. |
celerpy/model/input.py |
Replaces old ORANGE conversion options model with new CSG/Geant import option models and adds infix-related options. |
celerpy/model/output.py |
Adds tracking_logic to ORANGE params output and imports the new enum. |
celerpy/model/__init__.py |
Updates package-level re-exports to the renamed ORANGE input model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See celeritas-project/celeritas#2239