vide.tween added#65
Open
spidercraft wants to merge 3 commits intocentau:mainfrom
Open
Conversation
Author
|
Don’t worry, I made everything, check out my pull request! |
Owner
|
Hi, I appreciate the effort into this but I don't see this PR being merged, tweens have been asked for before and it was decided not to add them. Springs were chosen as the animation utility due to how they can smoothly handle rapid and abrupt updates, which work better with the design of vide effects. Lesser reasons are:
|
Author
|
i see, my bad i didn't knew about running outside of roblox's engine. That being said, i might make a fork of vide with just this added if people need it. Ty for your feedback tho |
Contributor
@centau @quantix-dev |
Author
|
updated the commit to use @HarryXChen3 's easings. |
Forgot to update a few stuff in my precedent commit. Everything is good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added vide.tween. Github test failed as im doing game:GetService("TweenService"), not sure if this is a issue or not?
It is needed for TweenService:GetValue()