cephadm-dashboard-e2e: replace docker with podman#2458
Conversation
|
i haven't tested this in the jenkins yet by updating the job configuration yet. Only done it in my local VM (which worked fine). Will wait for an approval before testing it out in the jenkins machines. |
7b9952b to
3e5f65a
Compare
|
replacing docker with podman. |
|
This is good as far as it goes, but I see two problems:
so this isn't sufficient, and I don't have time to make it better this week |
3e5f65a to
a9bcb59
Compare
@dmick i've modified the condition to check whether docker is installed through the docker official repo (docker-ce) and then only remove it. Maybe its more safer than before. Again I tried this out in my local VM which succesfully worked. |
| fi | ||
|
|
||
| podman info | ||
| podman container prune -f |
There was a problem hiding this comment.
Can I suggest instead you use https://github.com/ceph/ceph-build/blob/main/scripts/setup_container_runtime.sh
There was a problem hiding this comment.
yup, sure. I could give it a try. thanks
There was a problem hiding this comment.
sorry for the delay, but updated the PR now.
|
I mentioned this in DM but we might be able to do a manual one-time removal of docker and its ilk from the Jenkins builders and not worry about it here. Only the ceph-rook-e2e job still wants |
a9bcb59 to
9b8f4ff
Compare
so I removed the docker uninstall command from this PR since we just need it one time. Also I used to test the updated config with jenkins-job update command that pushes the config temporarily into the jenkins. but it doesn't work now and fails with 403 even though i have authenticated.. so maybe we need to merge and test this? |
9b8f4ff to
8cb2fc2
Compare
| kcli delete plan ceph -y || true | ||
| kcli delete network ceph-dashboard -y | ||
| kcli create pool -p /var/lib/libvirt/images/ceph-dashboard ceph-dashboard | ||
| kcli create network -c 192.168.100.0/24 ceph-dashboard |
There was a problem hiding this comment.
All kcli commands should run inside a sg libvirt -c 'kcli ...
There was a problem hiding this comment.
this would require changes in https://github.com/ceph/ceph/blob/main/src/pybind/mgr/dashboard/ci/cephadm/start-cluster.sh which require a bit more testing. should i handle it separately?
I am thinking maybe a wraparound would be better.. but it needs to be added for both scripts.
- cleanup the docker installation if its installed through docker-ce Signed-off-by: Nizamudeen A <nia@redhat.com>
8cb2fc2 to
90ddec5
Compare
djgalloway
left a comment
There was a problem hiding this comment.
Sure. Can't make things worse.
as per: #2458 (comment) Signed-off-by: Nizamudeen A <nia@redhat.com>
as per: ceph#2458 (comment) Signed-off-by: Nizamudeen A <nia@redhat.com>
as per: #2458 (comment) Signed-off-by: Nizamudeen A <nia@redhat.com>
Uh oh!
There was an error while loading. Please reload this page.