Skip to content

cephadm-dashboard-e2e: replace docker with podman#2458

Merged
djgalloway merged 1 commit intoceph:mainfrom
rhcs-dashboard:fix-docker-issue
Apr 1, 2026
Merged

cephadm-dashboard-e2e: replace docker with podman#2458
djgalloway merged 1 commit intoceph:mainfrom
rhcs-dashboard:fix-docker-issue

Conversation

@nizamial09
Copy link
Copy Markdown
Member

@nizamial09 nizamial09 commented Oct 6, 2025

  • cleanup the docker installation.

@nizamial09
Copy link
Copy Markdown
Member Author

i haven't tested this in the jenkins yet by updating the job configuration yet. Only done it in my local VM (which worked fine). Will wait for an approval before testing it out in the jenkins machines.

@nizamial09 nizamial09 changed the title cephadm-dashboard-e2e: install docker from ubuntu's repo cephadm-dashboard-e2e: replace docker with podman Oct 8, 2025
@nizamial09
Copy link
Copy Markdown
Member Author

replacing docker with podman.

@dmick
Copy link
Copy Markdown
Member

dmick commented Oct 14, 2025

This is good as far as it goes, but I see two problems:

  1. there are build hosts that have installed docker in the standard way from the standard repos, and rely on it, so "is docker present, if so remove it" is going to break those hosts

  2. the broken hosts will stay broken until they happen to be selected for a dashboard run

so this isn't sufficient, and I don't have time to make it better this week

@nizamial09
Copy link
Copy Markdown
Member Author

  1. there are build hosts that have installed docker in the standard way from the standard repos, and rely on it, so "is docker present, if so remove it" is going to break those hosts

@dmick i've modified the condition to check whether docker is installed through the docker official repo (docker-ce) and then only remove it. Maybe its more safer than before. Again I tried this out in my local VM which succesfully worked.

fi

podman info
podman container prune -f
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, sure. I could give it a try. thanks

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay, but updated the PR now.

@djgalloway
Copy link
Copy Markdown
Contributor

djgalloway commented Mar 25, 2026

I mentioned this in DM but we might be able to do a manual one-time removal of docker and its ilk from the Jenkins builders and not worry about it here. Only the ceph-rook-e2e job still wants docker. I pinged @rkachach asking if we can retire the job as it looks abandoned.

@nizamial09
Copy link
Copy Markdown
Member Author

I mentioned this in DM but we might be able to do a manual one-time removal of docker and its ilk from the Jenkins

so I removed the docker uninstall command from this PR since we just need it one time.

Also I used to test the updated config with jenkins-job update command that pushes the config temporarily into the jenkins. but it doesn't work now and fails with 403 even though i have authenticated..

  File "/usr/lib/python3.14/site-packages/requests/models.py", line 1026, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://jenkins.ceph.com/job/ceph-dashboard-cephadm-e2e/config.xml

so maybe we need to merge and test this?

Comment thread ceph-dashboard-cephadm-e2e/config/definitions/ceph-dashboard-cephadm-e2e.yml Outdated
Comment thread scripts/dashboard/install-cephadm-e2e-deps.sh Outdated
Comment on lines 72 to 75
kcli delete plan ceph -y || true
kcli delete network ceph-dashboard -y
kcli create pool -p /var/lib/libvirt/images/ceph-dashboard ceph-dashboard
kcli create network -c 192.168.100.0/24 ceph-dashboard
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All kcli commands should run inside a sg libvirt -c 'kcli ...

Copy link
Copy Markdown
Member Author

@nizamial09 nizamial09 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would require changes in https://github.com/ceph/ceph/blob/main/src/pybind/mgr/dashboard/ci/cephadm/start-cluster.sh which require a bit more testing. should i handle it separately?

I am thinking maybe a wraparound would be better.. but it needs to be added for both scripts.

- cleanup the docker installation if its installed through docker-ce

Signed-off-by: Nizamudeen A <nia@redhat.com>
Copy link
Copy Markdown
Contributor

@djgalloway djgalloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Can't make things worse.

@djgalloway djgalloway merged commit e221e5b into ceph:main Apr 1, 2026
1 check passed
nizamial09 added a commit that referenced this pull request Apr 2, 2026
as per: #2458 (comment)

Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09 added a commit to rhcs-dashboard/ceph-build that referenced this pull request Apr 12, 2026
as per: ceph#2458 (comment)

Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09 added a commit that referenced this pull request Apr 12, 2026
as per: #2458 (comment)

Signed-off-by: Nizamudeen A <nia@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants