Increase num_bytes_sent, no matter who calls mg_write#19
Increase num_bytes_sent, no matter who calls mg_write#19jharbott wants to merge 1 commit intoceph:wip-listen4from
Conversation
|
Hmm, I just gave this a test run and it seems to include the header size in the count, which is a bit unexpected when compared to the data one would usually see in other webserver's logs. Doing e.g. a GET of an object of 4 bytes size will show about 450 bytes being sent, the exact number depending on the metadata of the object. While this is not wrong in itself, I'm still wondering whether this is the solution we want or whether we want the pure content size to be logged, matching what the Content-Length header says. |
|
yeah that would be confusing |
|
Hi, is there any plan to merge this pr? Currently, the num_bytes_sent in civetweb's access log is always zero. We would better to merge this. |
|
so this will log total bytes sent in to the client, which I guess is acceptable from a webserver's pov |
mattbenjamin
left a comment
There was a problem hiding this comment.
as a reference, the bytes_transferred value in Apache trnasfer logs includes headers
http://httpd.apache.org/docs/current/mod/mod_log_config.html
This is a clean cherry-pick from upstream master. Partial fix for http://tracker.ceph.com/issues/19917