Fix bugs in possible policy-set path detection in cfbs-analyze #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiding the static dictionary or list used as a default function argument behind a `None` is not sufficient, as dictionary and list assignment in Python only assigns the reference, rather than cloning the contents. Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
…files; changed the error message to suggest real paths instead of (incorrectly) MPF-normalized paths Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
jakub-nt
force-pushed
the
analyze-possible-policyset-paths-fix
branch
3 times, most recently
from
d52bde3 to
ebd99c0
Compare
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
jakub-nt
force-pushed
the
analyze-possible-policyset-paths-fix
branch
from
ebd99c0 to
c4b8277
Compare
larsewi
approved these changes
Aug 12, 2025
| possible_policyset_relpaths = [] | ||
|
|
||
| for filepath in files_dict: | ||
| file_name = name(filepath) |
Contributor
There was a problem hiding this comment.
Preexisting, but is not this name() function the same as os.path.basename()? If so, why not use it instead?
Contributor
Author
There was a problem hiding this comment.
That could be done, I've simply never ended up doing so after writing the current implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.