ENT-13508: Fixed struct stat layout mismatch on HP-UX due to include order #5952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On HP-UX IA-64, verify_files_utils.c included <sys/types.h> before config.h was loaded, causing struct stat and off_t to use 32-bit layout instead of the 64-bit layout required by _FILE_OFFSET_BITS=64. This resulted in st_size being read from the wrong offset, producing garbage values (e.g., 236662833 instead of 821 bytes) and "file corrupted in transit" errors during local file copies. Fixed by including platform.h first to ensure _FILE_OFFSET_BITS=64 is defined before any system headers. Ticket: ENT-13508 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
HP-UX only: |
aleksandrychev
approved these changes
Nov 21, 2025
Contributor
Author
|
Backported to #5958 |
Contributor
Author
|
Backported to #5959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On HP-UX IA-64, verify_files_utils.c included <sys/types.h> before
config.h was loaded, causing struct stat and off_t to use 32-bit layout
instead of the 64-bit layout required by _FILE_OFFSET_BITS=64.
This resulted in st_size being read from the wrong offset, producing
garbage values (e.g., 236662833 instead of 821 bytes) and "file
corrupted in transit" errors during local file copies.
Fixed by including platform.h first to ensure _FILE_OFFSET_BITS=64 is
defined before any system headers.
Ticket: ENT-13508
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech