inventory/linux: Use Python script to check version#3088
Merged
nickanderson merged 1 commit intocfengine:masterfrom Apr 15, 2026
Merged
inventory/linux: Use Python script to check version#3088nickanderson merged 1 commit intocfengine:masterfrom
nickanderson merged 1 commit intocfengine:masterfrom
Conversation
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
craigcomstock
approved these changes
Dec 15, 2025
Member
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
Seems ok, but maybe it can be simplified further?
btriller
force-pushed
the
inventory-linux-python
branch
from
9a99650 to
e4a5fe5
Compare
nickanderson
approved these changes
Apr 13, 2026
Get rid of shells and other command and use Python itself for version check. Get major/minor via tuple for compatibility with very ancient Python versions (sys.version_info.major etc introduced in 2.7) [1]. [1] https://docs.python.org/2/library/sys.html#sys.version_info Co-Authored-By: Nick Anderson <nick@cmdln.org>
nickanderson
force-pushed
the
inventory-linux-python
branch
from
e4a5fe5 to
05a3b1d
Compare
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of shells and other command and use Python itself for version check.
Get major/minor via tuple for compatibility with very ancient Python versions (sys.version_info.major etc introduced in 2.7) [1].
[1] https://docs.python.org/2/library/sys.html#sys.version_info