CFE-4542: Added json promise type #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

olehermanse merged 1 commit into cfengine:master from victormlg:json-prmise-type

Jun 27, 2025

Contributor

victormlg commented Jun 24, 2025

No description provided.

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/test.cf Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/test.cf Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/json/json_promise.py Outdated Show resolved Hide resolved

victormlg force-pushed the json-prmise-type branch from c0c3b99 to c138b14 Compare

June 25, 2025 15:02

victormlg marked this pull request as ready for review

June 25, 2025 15:02

victormlg force-pushed the json-prmise-type branch 3 times, most recently from 1f2c9b0 to 9975fee Compare

June 26, 2025 11:16

victormlg requested a review from olehermanse

June 26, 2025 11:17

olehermanse requested changes

View reviewed changes

promise-types/json/json_promise_type.py Outdated Show resolved Hide resolved

promise-types/json/json_promise_type.py Outdated Show resolved Hide resolved

promise-types/json/json_promise_type.py Outdated Show resolved Hide resolved


          Added json promise type

40b9903

Signed-off-by: Victor Moene <victor.moene@northern.tech>

victormlg force-pushed the json-prmise-type branch from 9975fee to 40b9903 Compare

June 27, 2025 07:48

victormlg requested review from larsewi and olehermanse

June 27, 2025 07:48

larsewi requested changes

View reviewed changes

Contributor

larsewi left a comment

This looks very useful. Thanks for working on it! Added some comments

promise-types/json/README.md Show resolved Hide resolved

promise-types/json/README.md Show resolved Hide resolved

promise-types/json/example.cf Show resolved Hide resolved

promise-types/json/json_promise_type.py Show resolved Hide resolved

promise-types/json/json_promise_type.py Show resolved Hide resolved

promise-types/json/json_promise_type.py Show resolved Hide resolved

promise-types/json/json_promise_type.py Show resolved Hide resolved

promise-types/json/json_promise_type.py Show resolved Hide resolved

promise-types/json/json_promise_type.py Show resolved Hide resolved

promise-types/json/json_promise_type.py Show resolved Hide resolved

olehermanse approved these changes

View reviewed changes

Member

olehermanse left a comment

I don't see anything significant blocking this PR - I think you can review and consider / address all the comments in a smaller followup PR.

olehermanse merged commit 1b37ef9 into cfengine:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet