Open
Conversation
finally finished The Thing, trust me it's Fantastic. sorry for Dragging it for so long, this rewrite was Massive, but unlike the Low Taper this will never Fade. covered all bases (i think) except for 1. the animations, the offset variables aren't actually used, looks like. not experienced with the animation system in solar engine so i didn't bother touching it. 2. the weird bug when you fall off slopes when sliding at high speeds, although this happens in other states too so the bug might be a fundamental flaw with mario, not with this state. removing the first line in _on_enter makes it worse, this might be something to look into.
Also removes all instances of snap length being set in other states because that had no effect. Still need to find a way to make Mario stick to slopes when going up them.
direction now affects maxspeed not friction. feels pretty good to play i'd say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(copied from commit summary)
finally finished The Thing, trust me it's Fantastic. sorry for Dragging it for so long, this rewrite was Massive, but unlike the Low Taper this will never Fade.
covered all bases (i think) except for 1. the animations, the offset variables aren't actually used, looks like. not experienced with the animation system in solar engine so i didn't bother touching it.
2. the weird bug when you fall off slopes when sliding at high speeds, although this happens in other states too so the bug might be a fundamental flaw with mario, not with this state. removing the first line in _on_enter makes it worse, this might be something to look into.