Fix: keep line visible when zooming between data points#12176
Open
Akshat-0001 wants to merge 4 commits intochartjs:masterfrom
Open
Fix: keep line visible when zooming between data points#12176Akshat-0001 wants to merge 4 commits intochartjs:masterfrom
Akshat-0001 wants to merge 4 commits intochartjs:masterfrom
Conversation
When zooming into a range with no visible data points, the line controller skipped rendering entirely. This change includes boundary points before and after the visible range so line segments crossing the viewport are still drawn. Fixes chartjs#12174
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where line charts disappear when zooming into regions between widely spaced data points. The issue occurred because the line controller only rendered points strictly inside the visible range, causing line segments that cross the viewport to not be drawn.
Changes:
- Added
_includeBoundaryPointsmethod to find and include the nearest data points before and after the visible range - Modified the
updatemethod to call_includeBoundaryPointsbefore setting draw start and count - Moved the assignment of
_drawStartand_drawCountto after the boundary point inclusion
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12174
Problem
When zooming into a range that contains no data points
(between widely spaced points), the line chart disappears
even though the connecting line segment should be visible.
Cause
The line controller only rendered points strictly inside
the visible scale range. When zero points were visible,
no line segments were drawn.
Solution
Include the nearest boundary points (before and after the
visible range) when computing the draw window so line
segments crossing the viewport are rendered correctly.
Verification
sparse regions with zero visible points