fix(DatasetController): skip hidden datasets to improve performance#12183
Open
WAGHMARETANNU wants to merge 3 commits intochartjs:masterfrom
Open
fix(DatasetController): skip hidden datasets to improve performance#12183WAGHMARETANNU wants to merge 3 commits intochartjs:masterfrom
WAGHMARETANNU wants to merge 3 commits intochartjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #12179: "Charts with a large number of hidden datasets perform poorly".
When many datasets are present and most are hidden, Chart.js was still performing expensive parsing, stacking, and min/max calculations for hidden datasets. This caused noticeable lag in scenarios like time-tracking charts with 50+ datasets.
Changes
_resyncElementsnow skips processing for datasets wheremeta.hidden === true.getMinMaxreturns{ min: Infinity, max: -Infinity }for hidden datasets, avoiding unnecessary calculations.Benefits
Test
Issue
Closes #12179