fix(tooltip): add space between multiline labels in tooltip title#12186
Open
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Open
fix(tooltip): add space between multiline labels in tooltip title#12186jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Conversation
When chart labels are arrays (for multiline display on the axis), the tooltip title was joining them with comma only (e.g., 'Yellow,subTitle') instead of comma and space (e.g., 'Yellow, subTitle'). This fix joins array labels with ', ' for proper formatting in tooltips. Fixes chartjs#12049
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12049
When using array labels for multiline display (e.g.,
['Yellow', 'subTitle']), the tooltip was joining them with just a comma ('Yellow,subTitle') instead of a comma and space ('Yellow, subTitle').Changes
createTooltipIteminplugin.tooltip.jsto join array labels with', 'instead of relying on default array-to-string conversionTesting
Added a test case verifying that multiline array labels are properly joined with comma and space in the tooltip title.