fix(legend): respect horizontal padding for legend title#12187
Open
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Open
fix(legend): respect horizontal padding for legend title#12187jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Conversation
The legend title's horizontal paddings (left/right) were being ignored when calculating the x position. Only vertical padding was used. This fix accounts for titlePadding.left and titlePadding.right when calculating the title x position using _alignStartEnd. Fixes chartjs#12066
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12066
The legend title was not respecting the horizontal padding (
leftandright) specified intitlePadding. The title would be positioned without accounting for these padding values, causing visual misalignment.Changes
plugin.legend.jsto account fortitlePadding.leftandtitlePadding.rightwhen computing the title alignment positionBefore
After