fix: remove undocumented data_source empty/purge methods#186
Draft
wscourge wants to merge 3 commits intojessica/pip-309-ruby-sdk-feature-updatesfrom
Draft
fix: remove undocumented data_source empty/purge methods#186wscourge wants to merge 3 commits intojessica/pip-309-ruby-sdk-feature-updatesfrom
wscourge wants to merge 3 commits intojessica/pip-309-ruby-sdk-feature-updatesfrom
Conversation
Wraps external_id, data_source_uuid, invoice_external_id, include fields, and switch_system values with CGI.escape to prevent malformed URLs when values contain reserved characters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds RaiseError, retry, and User-Agent middleware to match the standard APIResource connection, ensuring consistent error handling and retries for multipart upload requests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These methods expose undocumented API endpoints (DELETE /data_sources/:uuid/all and DELETE /data_sources/:uuid/dependent) that should not be in the public SDK. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataSource#empty!andDataSource#soft_purge!methods that expose undocumented API endpointsTest plan
bundle exec rspec spec/chartmogul/data_source_spec.rbpasses🤖 Generated with Claude Code