Skip to content

Use real minus sign in “− Boosts”#1372

Merged
cheeaun merged 1 commit intocheeaun:mainfrom
valtlai:typography
Feb 12, 2026
Merged

Use real minus sign in “− Boosts”#1372
cheeaun merged 1 commit intocheeaun:mainfrom
valtlai:typography

Conversation

@valtlai
Copy link
Copy Markdown
Contributor

@valtlai valtlai commented Nov 26, 2025

- Boosts− Boosts

@cheeaun
Copy link
Copy Markdown
Owner

cheeaun commented Feb 12, 2026

Sorry for the late response and thanks for this.

But I prefer this to be less code-ish because I don't think translators will be able to see them. So instead of \u2212, will have to put the actual .

I'm also not sure why \xA0 is needed for the title?

As the translators might not be able to see the difference, adding a comment could be helpful. E.g.:

t({
  comment: 'Real minus character (−) is used here',
  message: `− Boosts`,
})
<Trans comment="Real minus character (−) is used here">− Boosts</Trans>

…so hopefully they can see this and copy paste the character 🤞

@valtlai valtlai changed the title Improve typography of “+ Replies” and “− Boosts” Use real minus sign in “− Boosts” Feb 12, 2026
@valtlai valtlai changed the title Use real minus sign in “− Boosts” Use real minus sign in “− Boosts” Feb 12, 2026
@valtlai
Copy link
Copy Markdown
Contributor Author

valtlai commented Feb 12, 2026

Okay, I replaced \u2212 with the literal character, removed \xA0, and added a comment for translators.

I'm also not sure why \xA0 is needed for the title?

The idea was to prevent (+ or (− and Replies) or Boosts) from being on separate lines:

Browser tab tooltip with a title having a line break after the plus signBrowser tab tooltip with a title having no line break after the plus sign

I think the latter looks better. But yeah, it’s hard to translate, because the no-break space looks like the regular space and not all translators know about no-break spaces.

@cheeaun
Copy link
Copy Markdown
Owner

cheeaun commented Feb 12, 2026

The files changed doesn't have en.po? If you run the dev server, it will auto-populate changes to en.po. Or you can manually run npm run messages:extract:clean.

What it does is it'll extract strings from all code files and put them nicely into en.po.

@valtlai
Copy link
Copy Markdown
Contributor Author

valtlai commented Feb 12, 2026

Added en.po

@cheeaun cheeaun merged commit ff4b407 into cheeaun:main Feb 12, 2026
5 checks passed
@valtlai valtlai deleted the typography branch February 13, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants