Skip to content

Refactored parts of the new ZGC parsing API to improve consistency#3

Open
chris-chedgey-sonarsource wants to merge 7 commits intomainfrom
pr455-after
Open

Refactored parts of the new ZGC parsing API to improve consistency#3
chris-chedgey-sonarsource wants to merge 7 commits intomainfrom
pr455-after

Conversation

@chris-chedgey-sonarsource
Copy link
Copy Markdown
Owner

@chris-chedgey-sonarsource chris-chedgey-sonarsource commented Mar 27, 2026 •
edited
Loading

Summary

Impact analysis

⬇️ Download interactive diagram (pan & zoom)

%%{init: {'flowchart': {'useMaxWidth': false}}}%%
graph LR
    subgraph gctoolkit_api["📦 gctoolkit-api"]
        subgraph gctoolkit_api_com_microsoft["📁 com.microsoft"]
            subgraph gctoolkit_api_com_microsoft_gctoolkit["📁 gctoolkit"]
                subgraph gctoolkit_api_com_microsoft_gctoolkit_event["📁 event"]
                    subgraph gctoolkit_api_com_microsoft_gctoolkit_event_zgc["📁 zgc"]
                        gctoolkit_api_com_microsoft_gctoolkit_event_zgc_OccupancySummary("Ⓒ OccupancySummary")
                        gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection("Ⓒ ZGCCollection")
                        gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCReclaimSummary("Ⓒ ZGCReclaimSummary")
                        gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCFullCollection("Ⓒ ZGCFullCollection")
                        gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCOldCollection("Ⓒ ZGCOldCollection")
                        gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCYoungCollection("Ⓒ ZGCYoungCollection")
                        gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCReclaimedSummary("Ⓒ ZGCReclaimedSummary")
                        gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCUsedSummary("Ⓒ ZGCUsedSummary")
                    end
                end
            end
        end
    end
    subgraph gctoolkit_parser["📦 gctoolkit-parser"]
        gctoolkit_parser_ZGCParser("Ⓒ ZGCParser")
    end
    subgraph gctoolkit_integration["📦 gctoolkit-integration"]
        gctoolkit_integration_HeapOccupancyAfterCollectionAggregator("Ⓒ HeapOccupancyAfterCollectionAggregator")
    end
    subgraph gctoolkit_sample["📦 gctoolkit-sample"]
        gctoolkit_sample_HeapOccupancyAfterCollection("Ⓒ HeapOccupancyAfterCollection")
    end
    classDef default fill:#fff,stroke:#d1d5db,color:#374151,rx:8,ry:8
    style gctoolkit_api fill:#5082BE33,stroke:#5082BE80,stroke-width:1.5px,rx:12,ry:12
    style gctoolkit_api_com_microsoft fill:#5082BE33,stroke:#5082BE80,stroke-width:1.5px,rx:12,ry:12
    style gctoolkit_api_com_microsoft_gctoolkit fill:#5082BE33,stroke:#5082BE80,stroke-width:1.5px,rx:12,ry:12
    style gctoolkit_api_com_microsoft_gctoolkit_event fill:#5082BE33,stroke:#5082BE80,stroke-width:1.5px,rx:12,ry:12
    style gctoolkit_api_com_microsoft_gctoolkit_event_zgc fill:#5082BE33,stroke:#5082BE80,stroke-width:1.5px,rx:12,ry:12
    style gctoolkit_parser fill:#5082BE33,stroke:#5082BE80,stroke-width:1.5px,rx:12,ry:12
    style gctoolkit_integration fill:#5082BE33,stroke:#5082BE80,stroke-width:1.5px,rx:12,ry:12
    style gctoolkit_sample fill:#5082BE33,stroke:#5082BE80,stroke-width:1.5px,rx:12,ry:12
    style gctoolkit_api_com_microsoft_gctoolkit_event_zgc_OccupancySummary stroke:#dc2626,stroke-width:3px
    style gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection stroke:#e67300,stroke-width:3px
    style gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCReclaimSummary stroke:#dc2626,stroke-width:3px
    style gctoolkit_parser_ZGCParser stroke:#e67300,stroke-width:3px
    style gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCReclaimedSummary stroke:#16a34a,stroke-width:3px
    style gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCUsedSummary stroke:#16a34a,stroke-width:3px
    gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_OccupancySummary
    gctoolkit_parser_ZGCParser -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_OccupancySummary
    gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCReclaimSummary
    gctoolkit_parser_ZGCParser -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCReclaimSummary
    gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection -->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCReclaimedSummary
    gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection -->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCUsedSummary
    gctoolkit_parser_ZGCParser -->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCReclaimedSummary
    gctoolkit_parser_ZGCParser -->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCUsedSummary
    gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCFullCollection -->|"extends, uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection
    gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCOldCollection -->|"extends, uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection
    gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCYoungCollection -->|"extends, uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection
    gctoolkit_integration_HeapOccupancyAfterCollectionAggregator -->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection
    gctoolkit_sample_HeapOccupancyAfterCollection -->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection
    gctoolkit_parser_ZGCParser -->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCCollection
    gctoolkit_integration_HeapOccupancyAfterCollectionAggregator -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCFullCollection
    gctoolkit_integration_HeapOccupancyAfterCollectionAggregator -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCOldCollection
    gctoolkit_integration_HeapOccupancyAfterCollectionAggregator -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCYoungCollection
    gctoolkit_sample_HeapOccupancyAfterCollection -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCFullCollection
    gctoolkit_sample_HeapOccupancyAfterCollection -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCOldCollection
    gctoolkit_sample_HeapOccupancyAfterCollection -.->|"uses"| gctoolkit_api_com_microsoft_gctoolkit_event_zgc_ZGCYoungCollection
    linkStyle 0,1,2,3 stroke:#dc2626,stroke-width:2px
    linkStyle 4,5,6,7 stroke:#16a34a,stroke-width:2px
Loading

🟠 modified · 🟢 added · 🔴 removed · solid = direct relationship to a changed class · dashed = relationship between impacted classes

Test plan

  • Verify ZGC parsing still produces correct events for all ZGC log formats (legacy, generational)
  • Verify ZGCCollection subclasses (Full/Old/Young) still instantiate correctly
  • Verify HeapOccupancyAfterCollectionAggregator and HeapOccupancyAfterCollection still handle ZGC events
  • Run ZGCParserTest and GenerationalZGCParserTest

🤖 Generated with Claude Code

dependabot bot and others added 7 commits August 10, 2025 10:23
@dependabot
Bump actions/cache from 4.2.3 to 4.2.4 (microsoft#451)
d61aecc 
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.3 to 4.2.4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@5a3ec84...0400d5f)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: 4.2.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/checkout from 4.2.2 to 5.0.0 (microsoft#452)
35bbe64 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@11bd719...08c6903)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/setup-java from 4.7.1 to 5.0.0 (microsoft#453)
329d0d5 
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.7.1 to 5.0.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@c5195ef...dded088)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jlittle-ptc
Fix "No Detail" Use Cases for Legacy and Generational ZGC logging (mi…
d42e404 
…crosoft#448)

* Apply fixes from FixNoDetailParsing branch.

* Test and fix sample Generational Events to ensure no extra events are created by NoDetails changes.

* Fix issue with GC Cause reporting found during test.

* Move non-detailed memory check into separate method per feedback.
@dependabot
Bump actions/cache from 4.2.4 to 4.3.0 (microsoft#454)
6ab6025 
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.4 to 4.3.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0400d5f...0057852)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: 4.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github/codeql-action from 3 to 4 (microsoft#456)
ac3f722 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v3...v4)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@fthevenet
Refactored parts of the new ZGC parsing API to improve consistency (m…
2b918d0 
…icrosoft#455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chris-chedgey-sonarsource @jlittle-ptc @fthevenet