feat: add per-deployment resource configuration for ghost and vao#264
Merged
WesleyCharlesBlake merged 2 commits intochronicleprotocol:pre_validator_0.7xfrom Feb 18, 2026
Conversation
- Add separate resource constraints for ghost and vao deployments - Update deployment templates to use deployment-specific resources with fallback to global - Bump chart version to 0.4.9 - Update documentation with new resource fields
Author
|
@paulohpigatto @teghnet could you please review this one |
Member
Thanks for this. We initially had seperate resource blocks, but then simplified it to global resources for ease of use. Im happy with this change, but we do have a pending validator release coming up soon, so I will include this PR in that release 👍🏻 |
WesleyCharlesBlake
merged commit f78c4f5
into
chronicleprotocol:pre_validator_0.7x
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to configure resource constraints independently for the
ghostandvaodeployments in the validator chart, while maintaining backward compatibility with the global resource configuration.Changes
ghost.resourcesfield in values.yaml for ghost deployment-specific resource constraintsvao.resourcesfield in values.yaml for vao deployment-specific resource constraintsdeployment.yamltemplate to useghost.resourceswith fallback toglobal.resourcesdeployment-vao.yamltemplate to usevao.resourceswith fallback toglobal.resourcesMotivation
Previously, both ghost and vao deployments shared the same resource constraints defined in
global.resources. This PR allows users to configure different resource limits and requests for each deployment independently, which is useful when:Backward Compatibility
This change is fully backward compatible. If
ghost.resourcesorvao.resourcesare not specified, the deployments will continue to useglobal.resourcesas before.Test Plan