sendRequestToOctoprint() debugging#29
Open
fmatray wants to merge 11 commits intochunkysteveo:masterfrom
Open
Conversation
- Resole issue chunkysteveo#28 - Reduce memory footprint with less variables - Split header sending in sendHeader() - Timeout run through all request - Refactor main loop for a better readability WARNING: Only tested with GET (Octoprint up and down with Haproxy, with printer up and down). Not tested yet with POST commands. Reduce variable memory for octoPrintPrintHeadRelativeJog() and remove a potential buffer overflow. Remove unsued maxMessageLength and httpErrorBody
…sconnect while waiting or reading data.
Contributor
Author
|
I tested POST commands with octoPrintPrintHeadRelativeJog() and octoPrintPrinterCommand(). It also included minor debugging and optimisations after several tests. |
Owner
|
You're keeping busy with this update! Impressive! Let me take a look at all your hard work @fmatray !! Thanks again! |
…n cash WifiNINA driver
Contributor
Author
|
I changed the delay during timeout, as the wifi driver crashs after a while. |
Contributor
Author
|
This PR adds a part of the issue #30 |
…. Not really tested and I don't have a chamber.
Contributor
Author
|
This PR adds chamber features to get and set temperatures. It also adds printerBedTempHistoryTarget to struct printerBedCall. |
Owner
|
Still want to have a play with all these updates first - i've not forgotten about this!!! :) |
Contributor
Author
|
I have less time now but, please, play theses features and tell me :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly to correct the issue #28. As discussed, there is no additional library dependency, so it should work and ESPxx and Arduino. I test on a MKR WIFI 1010.
I have only tested GET requests for the moment.
It's also add some debugs and optimisations.