Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Test vars in cli#38

Open
mourjo wants to merge 10 commits intocircleci:masterfrom
mourjo:test-vars-in-cli
Open

Test vars in cli#38
mourjo wants to merge 10 commits intocircleci:masterfrom
mourjo:test-vars-in-cli

Conversation

@mourjo
Copy link
Copy Markdown

@mourjo mourjo commented May 3, 2020

Mainly for running individual tests from the commandline #2

Some additional fixes:

  • Uniquify and sort nses and vars to test
  • Ensure test counts are not off with test-ns-hook
  • When vars or namespaces are not found do not throw error, test the other stuff if any
  • Additional project to test selectors
  • When a test calls another test, fixtures were run in Circleci but not in Leiningen or Clojure
  • When a test is run from within test-ns-hook, Leiningen does not run fixtures, but Circleci does
  • When there is a test-ns-hook, ensure only selected vars are tested

Mourjo Sen added 10 commits May 1, 2020 18:20
When using test-ns-hook, ensure no NPE in junit reporter
73d5521
Accept vars as input along with namespaces
e784fab
When test-ns-hook is used, ensure that unselected tests don't run
f34ea41 
This behaviour is the same as with Leiningen's test selectors.
When test-ns-hook is used, do not double count tests
f0eb40d 
When tests are run via test-ns-hook, clojure.test calls:
      (do-report {:type :begin-test-var, :var v})
      (inc-report-counter :test)

Which for circleci.test reports means that the test counter is
incremented twice.
When a namespace or var is not found, continue testing with others
8ab2c3c
Refactor commandline var selection code
e5ee679
Add tests for fixtures with var selectors
eaa8923
Ensure each fixtures are called atmost once for a test
2d35e34 
This behaviour is similar to Leiningen and Clojure test where if a
test calls another test, the once and each fixtures are called only
once.
Do not run fixtures in namespaces when using test-ns-hook
4fc6d36 
This is in accordance with clojure.test's definition of fixtures and
test-ns-hook:
   Note: Fixtures and test-ns-hook are mutually incompatible.  If you
   are using test-ns-hook, fixture functions will *never* be run.

Global fixtures still run.
Add a sample project to test selectors
999bd2b
@mourjo mourjo force-pushed the test-vars-in-cli branch from 78226f1 to 999bd2b Compare May 4, 2020 03:11
@mourjo
Copy link
Copy Markdown
Author

mourjo commented Jul 10, 2020

Any update on this? 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mourjo