feat(network)!: require PeerId in persistent peers configuration#1485
Closed
melekes wants to merge 3 commits intocirclefin:mainfrom
Closed
feat(network)!: require PeerId in persistent peers configuration#1485melekes wants to merge 3 commits intocirclefin:mainfrom
PeerId in persistent peers configuration#1485melekes wants to merge 3 commits intocirclefin:mainfrom
Conversation
Persistent peer addresses must include `PeerId`. Config and API now require the `/p2p/<peer_id>` component in every persistent peer address (e.g. `/ip4/1.2.3.4/tcp/9000/p2p/12D3KooW...`)
This comment was marked as outdated.
This comment was marked as outdated.
PeerId in persistent_peersPeerId in persistent peers configuration
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
I think we can make this change non-breaking, by allowing missing peer_ids for a few releases. Users who add /p2p/ get the protection, otherwise they get the old behavior. wdyt? |
Contributor
Is it breaking? Nodes that are restarted or upgraded need to have their configuration adapted, but existing nodes are not affected, are them? I mean, we can do it as part of a rolling upgrade. |
Contributor
|
Development of this PR has moved to a different repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1486
Requires `PeerId` in every persistent peer address (e.g. `/ip4/1.2.3.4/tcp/9000/p2p/12D3KooW...`). Config and API now require the `/p2p/<peer_id>` component.
Changes
Breaking change
Documented in `BREAKING_CHANGES.md`: persistent peer addresses must include `PeerId` (e.g. `/ip4/1.2.3.4/tcp/9000/p2p/12D3KooW...`).
PR author checklist
Contribution eligibility
For all contributors
RELEASE_NOTES.mdif the change warrants itBREAKING_CHANGES.mdif the change warrants itFor external contributors