test: Add more polka/commit certificate verification tests#1490
Merged
romac merged 1 commit intocirclefin:mainfrom Mar 10, 2026
Merged
test: Add more polka/commit certificate verification tests#1490romac merged 1 commit intocirclefin:mainfrom
romac merged 1 commit intocirclefin:mainfrom
Conversation
Add 32 new tests covering address spoofing, signature replay (across heights, rounds, and values), cross-type replay, validator set mismatch, and quorum boundary conditions for commit, polka, and round certificates. These tests prove that Malachite is resilient to the CometBFT vulnerability (fixed in cbccfe3) where lookUpByIndex allowed signature spoofing, because Malachite always looks up validators by address and verifies against the looked-up validator's public key.
romac
force-pushed
the
commit-verify-tests
branch
from
005657f to
c798f33
Compare
romac
changed the title
ancazamfir
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 32 new tests covering address spoofing, signature replay (across heights, rounds, and values), cross-type replay, validator set mismatch, and quorum boundary conditions for commit, polka, and round certificates.