Skip to content

Commit eb00798

Browse files
committed
fix WD doesn't ignore case of letter if check required browser and check required platform
1 parent 4fba3d1 commit eb00798

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/webdriver/webdriver_session.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ bool Session::CheckRequiredBrowser(const base::DictionaryValue* capabilities_dic
138138
if (capabilities_dict->GetString(Capabilities::kBrowserName, &required_browser)) {
139139
capabilities_.caps->GetString(Capabilities::kBrowserName, &actual_browser);
140140

141-
if (actual_browser != required_browser) {
141+
if (StringToLowerASCII(actual_browser) != StringToLowerASCII(required_browser)) {
142142
logger_.Log(kWarningLogLevel,
143143
"check failed - required browser("+required_browser+"), actual browser("+actual_browser+").");
144144
return false;
@@ -155,10 +155,10 @@ bool Session::CheckRequiredPlatform(const base::DictionaryValue* capabilities_di
155155
if (capabilities_dict->GetString(Capabilities::kPlatform, &required_platform)) {
156156
capabilities_.caps->GetString(Capabilities::kPlatform, &actual_platform);
157157

158-
if (required_platform == "ANY")
158+
if (StringToUpperASCII(required_platform) == "ANY")
159159
return true;
160160

161-
if (actual_platform != required_platform) {
161+
if (StringToLowerASCII(actual_platform) != StringToLowerASCII(required_platform)) {
162162
logger_.Log(kWarningLogLevel,
163163
"check failed - required platform("+required_platform+"), actual platform("+actual_platform+").");
164164
return false;

0 commit comments

Comments
 (0)