Skip to content

Fix ExaSock TCP seqnum off-by-one error in EXA_TCP_FIN_WAIT_2 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakobWyatt wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

Fix ExaSock TCP seqnum off-by-one error in EXA_TCP_FIN_WAIT_2 #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56eb0ce
Fix send_seq not including FIN in EXA_TCP_FIN_WAIT_2
JakobWyatt Mar 23, 2026
927c8c2
increment seqnum when sending from EXA_TCP_FIN_WAIT_2 in kernel module
JakobWyatt Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/exasock/tcp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ exa_tcp_build_ctrl(struct exa_tcp_conn * restrict ctx, char ** restrict hdr,

case EXA_TCP_FIN_WAIT_2:
/* Send ACK */
h->th_seq = htonl(state->send_seq);
h->th_seq = htonl(state->send_seq + 1);
h->th_ack = htonl(recv_seq);
h->th_flags = TH_ACK;
PROFILE_INFO_TCP_TX_RX_EVENT(false, ctx, EXA_TCP_FIN_WAIT_2, 0, 1, state->send_seq, recv_seq);
Expand Down
3 changes: 2 additions & 1 deletion modules/exasock/exasock-tcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3817,7 +3817,8 @@ static void exasock_tcp_send_ack(struct exasock_tcp *tcp, bool dup)
struct exa_socket_state *state = tcp->user_page;
uint32_t seq = state->p.tcp.send_seq;
if (state->p.tcp.state == EXA_TCP_TIME_WAIT ||
state->p.tcp.state == EXA_TCP_CLOSING)
state->p.tcp.state == EXA_TCP_CLOSING ||
state->p.tcp.state == EXA_TCP_FIN_WAIT_2)
{
seq++;
}
Expand Down