-
Notifications
You must be signed in to change notification settings - Fork 31
Migrate the repository tooling to Rolldown and isolated declarations. #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
8a79821
c0917ff
2886052
8385665
e9caff2
2d361ea
d080d01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,13 +57,13 @@ | |
| "@types/node": "^22.14.1", | ||
| "@types/postcss-mixins": "^9.0.5", | ||
| "@vitest/coverage-v8": "^4.0.18", | ||
| "rolldown": "^1.0.0-rc.4", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While I can accept isolated declarations, I am opposed to using unstable dependencies.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not understand why we migrate partially.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I propose to merge isolated declarations if this PR focuses only on them. Once |
||
| "type-fest": "^4.10.2", | ||
| "typescript": "5.5.4", | ||
| "vitest": "^4.0.18" | ||
| }, | ||
| "scripts": { | ||
| "build": "rollup -c rollup.config.js --forceExit", | ||
| "dev": "rollup -c rollup.config.js --watch", | ||
| "build": "rolldown -c rolldown.config.js", | ||
| "dev": "rolldown -c rolldown.config.js --watch", | ||
| "test": "vitest run --config vitest.config.ts", | ||
| "coverage": "vitest run --config vitest.config.ts --coverage", | ||
| "test:dev": "vitest dev" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /** | ||
| * @license Copyright (c) 2003-2026, CKSource Holding sp. z o.o. All rights reserved. | ||
| * For licensing, see LICENSE.md. | ||
| */ | ||
|
|
||
| import { defineConfig } from 'rolldown'; | ||
| import { declarationFilesPlugin } from '../../scripts/plugin-declarations.js'; | ||
| import pkg from './package.json' with { type: 'json' }; | ||
|
|
||
| const externals = [ | ||
| ...Object.keys( pkg.dependencies || {} ), | ||
| ...Object.keys( pkg.peerDependencies || {} ) | ||
| ]; | ||
|
|
||
| export default defineConfig( { | ||
| input: 'src/index.ts', | ||
| platform: 'node', | ||
| output: { | ||
| cleanDir: true, | ||
| format: 'esm', | ||
| dir: 'dist', | ||
| assetFileNames: '[name][extname]' | ||
| }, | ||
| plugins: [ | ||
| declarationFilesPlugin() | ||
| ], | ||
| external: id => externals.some( name => id.startsWith( name ) ) | ||
| } ); |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /** | ||
| * @license Copyright (c) 2003-2026, CKSource Holding sp. z o.o. All rights reserved. | ||
| * For licensing, see LICENSE.md. | ||
| */ | ||
|
|
||
| import { defineConfig } from 'rolldown'; | ||
| import { declarationFilesPlugin } from '../../scripts/plugin-declarations.js'; | ||
| import pkg from './package.json' with { type: 'json' }; | ||
|
|
||
| const externals = [ | ||
| ...Object.keys( pkg.dependencies || {} ), | ||
| ...Object.keys( pkg.peerDependencies || {} ) | ||
| ]; | ||
|
|
||
| export default defineConfig( { | ||
| input: { | ||
| index: 'src/index.ts', | ||
| template: 'src/template.ts' | ||
| }, | ||
| platform: 'node', | ||
| output: { | ||
| cleanDir: true, | ||
| format: 'esm', | ||
| dir: 'dist', | ||
| assetFileNames: '[name][extname]' | ||
| }, | ||
| external: id => externals.some( name => id.startsWith( name ) ), | ||
| plugins: [ | ||
| declarationFilesPlugin() | ||
| ] | ||
| } ); |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.