Add search functionality by bundle identifier in app list#652
Open
ismailcarlik wants to merge 2 commits into
Open
Add search functionality by bundle identifier in app list#652ismailcarlik wants to merge 2 commits into
ismailcarlik wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds app ID matching to the in-table search filter so users can find apps by identifier in addition to name/description fields.
Changes:
- Extend search predicate to also match
app.id. - Keep existing search behavior for name/description/subtitle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted improvement to the app search functionality. Now, when filtering apps, the search will also consider matches in the app's
idfield, in addition to name, description, and subtitle._calculateSortedAppsmethod inSourceAppsTableRepresentableView.Coordinatorto include the app'sidfield in the search filter, allowing users to find apps by their bundle IDs.