fix(computer-use): add /System/Applications to installed app scan dirs

[Icarus603]

Summary

• Adds /System/Applications to the listInstalled() search directories in darwin.ts
• Ensures Apple system apps (Safari, Notes, Maps, Calendar, etc.) are included in the installed app list
• macOS 10.15+ (Catalina) moved bundled Apple apps from /Applications to /System/Applications

Test plan

• Run list_granted_applications or trigger listInstalled() and verify system apps like Safari appear
• Confirm no regressions for apps in /Applications and ~/Applications

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

• New Features

  • Buddy companion now displays character stats and supports new commands: /buddy rehatch (re-roll companion), /buddy mute, and /buddy unmute
  • Additional feature flags enabled for clipboard image support and advanced capabilities

• Improvements

  • Enhanced multi-monitor support with improved coordinate tracking
  • Better app window management and visibility on macOS
  • Royal Gold Dark theme now default for dark mode
  • Improved image capture with optimized processing and JPEG conversion
  • Refined color palette and diff visualization across themes

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dfdc2cab-13ee-48cb-b70e-08927f33271f

📥 Commits

Reviewing files that changed from the base of the PR and between cf26c73 and 775afe4.

⛔ Files ignored due to path filters (1)

• contributors.svg is excluded by !**/*.svg

📒 Files selected for processing (26)

• build.ts
• packages/@ant/computer-use-swift/src/backends/darwin.ts
• packages/color-diff-napi/src/index.ts
• packages/image-processor-napi/src/index.ts
• scripts/dev.ts
• src/commands/buddy/buddy.ts
• src/commands/buddy/index.ts
• src/components/FullscreenLayout.tsx
• src/components/HighlightedCode.tsx
• src/components/LogoV2/ExperimentEnrollmentNotice.tsx
• src/components/LogoV2/GateOverridesWarning.tsx
• src/components/LogoV2/LogoV2.tsx
• src/components/Spinner/GlimmerMessage.tsx
• src/components/Spinner/SpinnerAnimationRow.tsx
• src/components/Spinner/SpinnerGlyph.tsx
• src/components/ThemePicker.tsx
• src/hooks/usePasteHandler.ts
• src/services/api/openai/convertMessages.ts
• src/tools/FileReadTool/FileReadTool.ts
• src/utils/computerUse/escHotkey.ts
• src/utils/computerUse/executor.ts
• src/utils/computerUse/hostAdapter.ts
• src/utils/earlyInput.ts
• src/utils/imagePaste.ts
• src/utils/markdown.ts
• src/utils/theme.ts

---

📝 Walkthrough

Walkthrough

This PR adds numerous feature flags to build configuration, significantly refactors macOS computer-use backends with improved display geometry and app enumeration, introduces brand color constants across theming, converts clipboard image reading to async, redesigns the buddy companion command (removing JSX, adding mute/unmute/rehatch), and removes stalled-intensity visual feedback from spinner components.

Changes

Cohort / File(s)	Summary
Build & Feature Configuration build.ts, scripts/dev.ts	Added 16 new feature flags (BUDDY, NATIVE_CLIPBOARD_IMAGE, BRIDGE_MODE, MCP_SKILLS, etc.) and updated inline comments to mark P0/P1 entries as "(upstream)".
macOS Computer Use Backend packages/@ant/computer-use-swift/src/backends/darwin.ts	Display geometry now includes per-display origin coordinates; app preparation/visibility logic substantially refactored to enumerate foreground apps via JXA, hide/activate allowlisted apps; app enumeration switched to JXA/NSBundle approach; screenshot capture refactored to resize/convert to JPEG via sips command and parse dimensions from JPEG headers.
Computer Use Executor & Permissions src/utils/computerUse/executor.ts, src/utils/computerUse/hostAdapter.ts, src/utils/computerUse/escHotkey.ts	Executor now augments screenshot/display results with missing coordinate/origin fields and broadens clipboard-mode typing on macOS for non-ASCII text; hostAdapter replaced native Swift permission checks with Bun FFI calls to system frameworks; escHotkey calls made null-safe via optional chaining.
Image & Clipboard Processing packages/image-processor-napi/src/index.ts, src/utils/imagePaste.ts, src/tools/FileReadTool/FileReadTool.ts, src/hooks/usePasteHandler.ts	readClipboardImage converted from synchronous to async; macOS image resize fallback added using sips pipeline; paste handler error handling improved with per-path .catch and safety-net .catch block.
Buddy Companion Command src/commands/buddy/buddy.ts, src/commands/buddy/index.ts	Removed React/JSX rendering, replaced with text output; added /buddy mute//buddy unmute (replacing on/off) and new /buddy rehatch subcommand; introduced renderStats() helper for formatted stat display; updated command metadata.
Color, Theme & Markdown packages/color-diff-napi/src/index.ts, src/utils/theme.ts, src/utils/markdown.ts	Introduced brand color constants (BRAND_COLOR, BRAND_RED, BRAND_GREEN) replacing hardcoded RGB values; dark theme default syntax highlighting changed to "Royal Gold Dark"; inline code coloring now theme-dependent.
Spinner & Stalled Visual Feedback src/components/Spinner/GlimmerMessage.tsx, src/components/Spinner/SpinnerAnimationRow.tsx, src/components/Spinner/SpinnerGlyph.tsx	Removed all stalledIntensity-based color interpolation and stalled visual feedback logic across spinner components.
UI Components & Layout src/components/FullscreenLayout.tsx, src/components/HighlightedCode.tsx, src/components/ThemePicker.tsx, src/components/LogoV2/*	FullscreenLayout simplified sticky-header model; HighlightedCode added duplicate import and changed fallback coloring behavior; ThemePicker now reads settings via hook; added stub ExperimentEnrollmentNotice and GateOverridesWarning components.
Escape Sequence & Message Handling src/utils/earlyInput.ts, src/services/api/openai/convertMessages.ts	Escape sequence skipping refactored to handle CSI/DCS/OSC/APC/PM/SOS sequences per ECMA-48 standard; tool result messages now ordered before corresponding user messages in OpenAI conversion.

Sequence Diagram(s)

sequenceDiagram
    participant caller as Command Handler
    participant darwin as darwin.ts<br/>(prepareDisplay)
    participant jxa as JXA Script
    participant sysev as System Events
    participant fs as Filesystem
    
    caller->>darwin: prepareDisplay(allowlistBundleIds)
    darwin->>jxa: enumerate visible foreground apps
    jxa-->>darwin: app list with bundle IDs
    
    loop For each visible app
        alt app in allowlist or is Finder
            darwin->>darwin: skip (keep visible)
        else
            darwin->>sysev: hide application
            sysev-->>darwin: hidden
        end
    end
    
    darwin->>jxa: activate first allowlisted running app
    jxa-->>darwin: activated
    darwin->>darwin: Bun.sleep(150)
    darwin-->>caller: { activated, hidden }

Loading

sequenceDiagram
    participant user as User
    participant buddy as buddy command
    participant config as Global Config
    participant display as Display
    
    user->>buddy: /buddy rehatch
    buddy->>buddy: generate new seed
    buddy->>buddy: re-roll companion
    buddy->>config: persist as StoredCompanion
    config-->>buddy: confirmed
    buddy->>buddy: renderStats(stats)
    buddy->>display: output sprite + name + traits + rendered stats
    display-->>user: "Companion replaced!"

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

• 合并最新主分支 #36 — Buddy feature companion seeding and command registration directly overlap with the buddy redesign in this PR.
• Feature/computer use/mac support #108 — macOS Computer Use backend (darwin.ts, hostAdapter.ts, hotkey handling) implements overlapping changes to the same files.
• fix: 启动时 iTerm2 终端响应序列泄漏到 REPL 输入框 #172 — Early input escape sequence handling in src/utils/earlyInput.ts implements the same ECMA-48 CSI/OSC/DCS refactoring pattern.

Suggested reviewers

• KonghaYao

---

🐰 A buddy's reborn with a fresh roll of dice,
Colors now branded—theme shades looking nice!
Screens stretching wide with their origins bright,
Escape sequences tamed in their ECMA flight,
Async clipboards blur the sync/async line—
hop, hop, hop! ✨ The refactor's divine!

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch fix/computer-use-system-apps-scan

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}