Skip to content

Inherit the default background#15

Open
gsingh93 wants to merge 1 commit intoclemera:masterfrom
gsingh93:background
Open

Inherit the default background#15
gsingh93 wants to merge 1 commit intoclemera:masterfrom
gsingh93:background

Conversation

@gsingh93
Copy link
Copy Markdown

  • I have signed the copyright paperwork for contributing to GNU Emacs.

Is the decision to set the default background face to "old lace" intentional? It's currently causing issues on some darker themes, which forces users to customize it. I think leaving it as the default would be better.

Before:
image

After:
image

@rusubov
Copy link
Copy Markdown

rusubov commented Jun 21, 2024

I think I've come across this issue when using the frog-jump-mode. I have dark mode enabled, so all I got was light letters on a light background. This made frog-jump-mode really hard to use. I think this PR may fix the issue for me.

@clemera Can we get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants