Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BrandonRomano
left a comment
BrandonRomano
left a comment
There was a problem hiding this comment.
This LGTM - I would also wait for approval from @jescalan here as well!
|
@brunol95 added blocked label for now as the SDK PR is still awaiting review and release clerk/javascript#7883 |
|
|
||
| You can then fulfill the request, or reject it if the token is invalid. | ||
|
|
||
| > [!NOTE] |
There was a problem hiding this comment.
Two things on this:
- I think this callout should also be added to this page: https://clerk.com/docs/pr/bruno-jwt-m2m-tokens/reference/backend/m2m-tokens/verify-token?
- This method
getTokens()doesnt seem to be documented in this page or the JS Backend SDK M2M Tokens methods?
There was a problem hiding this comment.
the doc for the method will be added in https://github.com/clerk/clerk-docs/pull/3165/changes
…/jwt-m2m-tokens
…-docs into bruno/jwt-m2m-tokens
|
@brunol95 Okay submitted a docs review. But all looks good to me. Let me know what you think of the changes and I'll approve! |
@SarahSoutoul I pushed one more commit. Thank you for the review! I think its good to go. |
SarahSoutoul
left a comment
SarahSoutoul
left a comment
There was a problem hiding this comment.
Good to go! Thank you @brunol95
Co-authored-by: Michael Novotny <manovotny@gmail.com> Co-authored-by: Sarah Soutoul <sarah@clerk.dev>
6 participants
🔎 Previews:
What does this solve? What changed?
We are adding the ability to create M2M tokens as a jwt. This PR updates the relevant documentation on
Deadline
No rush