Skip to content

fix(clerk-js): Don't render switch button on default plans #8116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brkalow merged 1 commit into from
Mar 19, 2026
Merged

fix(clerk-js): Don't render switch button on default plans #8116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/some-birds-know.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Fix issue where "Manage Subscription" button appeared on default free plans.
5 changes: 4 additions & 1 deletion packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ const valueResolution = (params: UsePricingFooterStateParams): [boolean, boolean
// Active subscription
if (subscription.status === 'active') {
const isCanceled = !!subscription.canceledAt;
const isSwitchingPaidPeriod = planPeriod !== subscription.planPeriod && Boolean(plan.annualMonthlyFee);
const isSwitchingPaidPeriod =
!subscription.plan.isDefault &&
planPeriod !== subscription.planPeriod &&
((planPeriod === 'annual' && Boolean(plan.annualMonthlyFee)) || (planPeriod === 'month' && Boolean(plan.fee)));
Copy link
Member

@mzhong9723 mzhong9723 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Looks like you fixed something additional here? Could you give a bit more context?

Copy link
Member Author

@dstaley dstaley Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, that branch was checking planPeriod === 'annual' && Boolean(plan.annualMonthlyFee) (so, the desired plan period is annual and the plan has an annual monthly fee). I added the planPeriod === 'monthly' && Boolean(plan.fee) to account for annual-only plans.

const isActiveFreeTrial = plan.freeTrialEnabled && subscription.isFreeTrial;

if (isCanceled || isSwitchingPaidPeriod) {
Expand Down
Loading