Skip to content

fix(ci): correct playwright trace upload path#8131

Merged
jacekradko merged 6 commits intomainfrom
jacek/fix-playwright-trace-upload
Mar 20, 2026
Merged

fix(ci): correct playwright trace upload path#8131
jacekradko merged 6 commits intomainfrom
jacek/fix-playwright-trace-upload

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Mar 20, 2026

Summary

  • Fix Playwright trace artifact upload path in CI workflows
  • Tests run from the repo root via pnpm playwright test --config integration/playwright.config.ts, so traces are written to test-results/ at the repo root — but the upload steps were looking at integration/test-results, which doesn't exist
  • Fixes ci.yml, e2e-staging.yml, and nightly-checks.yml

Test plan

  • Trigger a failing e2e-staging run and verify trace artifacts appear on the workflow run page
  • Download trace artifact and confirm it contains valid trace.zip files viewable with npx playwright show-trace

Summary by CodeRabbit

  • Chores
    • Updated CI workflow artifact upload paths used for collecting integration/e2e/nightly test results so test artifacts are gathered correctly.
    • Added a new Changeset metadata file.

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 20, 2026 1:41am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2026

🦋 Changeset detected

Latest commit: c186a00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: dc4cf576-9506-443f-8afd-a55fcfda268f

📥 Commits

Reviewing files that changed from the base of the PR and between e5d8d2a and c186a00.

📒 Files selected for processing (2)
  • .changeset/yellow-eagles-shine.md
  • .github/workflows/e2e-staging.yml

📝 Walkthrough

Walkthrough

Three GitHub Actions workflow files (.github/workflows/ci.yml, .github/workflows/e2e-staging.yml, .github/workflows/nightly-checks.yml) were updated to change artifact upload paths from integration/test-results to test-results in their integration test jobs; artifact names, retention settings, and execution conditions were not modified. A new Changeset file .changeset/yellow-eagles-shine.md containing only YAML frontmatter (---) was also added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: correcting the Playwright trace upload path in CI workflows from an incorrect nested path to the correct root-level path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 20, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8131

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8131

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8131

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8131

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8131

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8131

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8131

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8131

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8131

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8131

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8131

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8131

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8131

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8131

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8131

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8131

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8131

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8131

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8131

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8131

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8131

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8131

commit: c186a00

@jacekradko jacekradko merged commit d304496 into main Mar 20, 2026
42 of 44 checks passed
@jacekradko jacekradko deleted the jacek/fix-playwright-trace-upload branch March 20, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants