chore(repo): remove playground templates#8533
Open
jacekradko wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a6e8380 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (20)
📒 Files selected for processing (172)
💤 Files with no reviewable changes (171)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR removes the repository's playground templates and references across configs, scripts, editor settings, and many playground subprojects. It deletes playground app source files, package manifests, TypeScript and tooling configs, styles, and assets; removes playground entries from .gitignore, .dockerignore, .prettierignore, ESLint, Renovate, and GitHub labeler configs; updates monorepo development docs and cursor rules to target packages/ workflows; and adjusts scripts (format, nuke, renovate generator) and VS Code launch configurations accordingly. A changeset documenting the removal was added. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.changeset/remove-playground-templates.md (1)
1-4: ⚡ Quick winPrefer a truly empty changeset for this no-bump repo cleanup.
If this PR is intentionally release-neutral, keep only the
---delimiters and remove the body text to match the repo’s documented no-bump pattern.Proposed change
--- --- - -Remove playground templates from the repository.Based on learnings, in this repo an empty
.changeset/*.mdfile (only delimiters) is acceptable for documentation/no-version-bump changes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.changeset/remove-playground-templates.md around lines 1 - 4, The changeset contains extraneous body text between the front-matter delimiters; update the .changeset file so it is truly empty by removing all text between the two '---' delimiters and leaving only the two '---' lines (no body content), ensuring the file matches the repo's no-bump/empty changeset pattern.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.changeset/remove-playground-templates.md:
- Around line 1-4: The changeset contains extraneous body text between the
front-matter delimiters; update the .changeset file so it is truly empty by
removing all text between the two '---' delimiters and leaving only the two
'---' lines (no body content), ensuring the file matches the repo's
no-bump/empty changeset pattern.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 78882dba-ed85-4618-8217-204920280788
📒 Files selected for processing (14)
.changeset/remove-playground-templates.md.cursor/rules/development.mdc.cursor/rules/global.mdc.cursor/rules/monorepo.mdc.dockerignore.github/labeler.yml.gitignore.prettierignore.vscode/launch.jsoneslint.config.mjsrenovate.json5scripts/format-non-workspace.mjsscripts/nuke.mjsscripts/renovate-config-generator.mjs
💤 Files with no reviewable changes (12)
- .dockerignore
- .cursor/rules/development.mdc
- .cursor/rules/monorepo.mdc
- .cursor/rules/global.mdc
- eslint.config.mjs
- .prettierignore
- renovate.json5
- scripts/format-non-workspace.mjs
- scripts/renovate-config-generator.mjs
- .vscode/launch.json
- .github/labeler.yml
- scripts/nuke.mjs
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
playground/directory and the demo apps inside (Next.js, Expo, Express, Fastify, browser extensions, CRA, Vite, vanilla JS, React Router). They were never pnpm workspace members and CI did not exercise them, so they had drifted from the rest of the repo. With them gone, this also cleans up the playground entries in.gitignore,.prettierignore,.dockerignore, ESLint config, the VSCode launch profiles, the GitHub labeler, the cursor rules, andscripts/{nuke,renovate-config-generator,format-non-workspace}.mjs.renovate.json5was regenerated.Local sanity:
pnpm installandpnpm format:checkpass.pnpm linthits a pre-existing failure on.github/actions/ensure-stable-pr/action.ymlthat also reproduces onmain, so it is unrelated to this change.