SHA pin first-party GitHub Actions#25
Merged
Merged
Conversation
Pins every actions/* and github/* uses: reference in .github/workflows to its commit SHA, with the human-readable version preserved in a trailing comment, matching the convention already used for third-party actions. Removes the supply-chain exposure left by floating @vn tags now that dependabot has a 3-day cooldown configured. Follows cli/cli#13491 (cli/cli) and cli/cli#13490. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
williammartin
requested review from
BagToad and
Copilot
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the org-wide rollout following cli/cli#13491. See cli/cli#13490 for full rationale.
What
Replaces every
actions/*andgithub/*uses:reference in.github/workflows/*.ymlwith the equivalent commit SHA, preserving the human-readable version in a trailing comment. Matches the convention already used for third-party action pins.Unique pins introduced:
actions/checkoutde0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2actions/setup-go4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0github/codeql-action/init7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4.36.0github/codeql-action/analyze7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4.36.0Why
With the 3-day dependabot cooldown configured for
github-actions, version-tag references give no real benefit (dependabot still opens PRs on patch releases) while leaving us exposed to tag-mutation supply chain attacks on first-party namespaces. SHA pinning is the more consistent and defensible posture.Verification
@vNrefs remain.<sha> # vX.Y.Zpins and will bump both the SHA and the comment on the next patch release.Opened as a draft for review; mark ready when checks pass.