Remove physical module layout info from read sets#5149
Open
joshua-spacetime wants to merge 5 commits into
Open
Remove physical module layout info from read sets#5149joshua-spacetime wants to merge 5 commits into
joshua-spacetime wants to merge 5 commits into
Conversation
joshua-spacetime
force-pushed
the
joshua/fix/view-fn-ptr
branch
from
20f7181 to
decad9f
Compare
joshua-spacetime
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
I believe this to fix #4947.
Previously, committed read sets stored module-local indexes used for view dispatch. These indexes are not stable across module updates, but they were not removed from the committed state, so that later when a write triggered a view refresh, the runtime could dispatch the wrong view function or attempt to materialize into the wrong backing table which would result in a fatal error.
This patch removes these unstable indexes from read sets. The core behavior change is that committed read sets no longer depend on stale per-module layout details. They identify the logical view call, and refresh resolves the current module metadata when needed.
API and ABI breaking changes
N/A
Expected complexity level and risk
2
Testing