Skip to content

feat: include the Response object in NextcloudException#394

Merged
kyteinsky merged 1 commit intomainfrom
feat/noid/inc-response-in-exc
Feb 4, 2026
Merged

feat: include the Response object in NextcloudException#394
kyteinsky merged 1 commit intomainfrom
feat/noid/inc-response-in-exc

Conversation

@kyteinsky
Copy link
Contributor

Fixes # .

Changes proposed in this pull request:

  • Include the Response object for the downstream apps can get the full error response and anything else in the object.

@kyteinsky kyteinsky requested review from bigcat88 and oleksandr-nc and removed request for bigcat88 February 3, 2026 15:44
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.65%. Comparing base (7ebe4c3) to head (7871751).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nc_py_api/files/_files.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          45       45           
  Lines        5389     5392    +3     
=======================================
+ Hits         5101     5104    +3     
  Misses        288      288           
Files with missing lines Coverage Δ
nc_py_api/_exceptions.py 100.00% <100.00%> (ø)
nc_py_api/_session.py 94.73% <100.00%> (ø)
nc_py_api/files/_files.py 98.65% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-implemented, backward-compatible enhancement 👍

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@kyteinsky kyteinsky force-pushed the feat/noid/inc-response-in-exc branch from 5532ac3 to 7871751 Compare February 4, 2026 07:08
@kyteinsky kyteinsky merged commit dafd3b4 into main Feb 4, 2026
12 checks passed
@kyteinsky kyteinsky deleted the feat/noid/inc-response-in-exc branch February 4, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants