Skip to content

File-scoped namespaces and other improvements#28

Closed
Banovvv wants to merge 4 commits intocloudconvert:masterfrom
Banovvv:major-improvements
Closed

File-scoped namespaces and other improvements#28
Banovvv wants to merge 4 commits intocloudconvert:masterfrom
Banovvv:major-improvements

Conversation

@Banovvv
Copy link
Contributor

@Banovvv Banovvv commented Mar 12, 2026

File-scoped namespaces and other improvements

  • Fixed += string mutation
  • Fixed HashHMAC to dispose properly
  • Used StringBuilder in CreateSignedUrl to avoid repeated string allocations
  • Added AddCloudConvertAPI() extension method with DI support
  • Updated README.md

@josiasmontag
Copy link
Contributor

Thanks for your contribution!
Unfortunately, it is hard to review this PR because it changes the indentation in all files.
Can you either undo this or alternatively split up the PR so that we can see the actual changes?

@Banovvv
Copy link
Contributor Author

Banovvv commented Mar 12, 2026

@josiasmontag the indentation is a side-effect of the file-scoped namespaces. I'll do what you suggest and create a second PR only with the file-scoped namespaces.

@Banovvv Banovvv closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants