Update pull_request_template.md#3
Open
josisusan wants to merge 1 commit intocloudfactory:masterfrom
josisusan:patch-1
Open
Update pull_request_template.md#3josisusan wants to merge 1 commit intocloudfactory:masterfrom josisusan:patch-1
josisusan wants to merge 1 commit intocloudfactory:masterfrom
josisusan:patch-1
Conversation
Add checklist for the following list: - Adding Changelog - Update service-version - Update config-version
Author
|
Changes:
|
Comment on lines
+16
to
+18
| - [ ] Add Changelog | ||
| - [ ] Update Service version | ||
| - [ ] Update Config version |
There was a problem hiding this comment.
Suggested change
| - [ ] Add Changelog | |
| - [ ] Update Service version | |
| - [ ] Update Config version | |
| - [ ] 🗄️ I have added the Changelog | |
| - [ ] 📦 I have updated the Service version | |
| - [ ] 🔧 I have updated the Config version | |
| - [ ] ⚡ I have tested performance of lambda api endpoint using Jaeger trace |
Contributor
|
Need to update the template file that is in the root folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link:
Component Name:
Summary/Motivation:
Documentation:
Testing Strategy:
Dependencies:
Screenshots and GIF:
Deployment Strategy:
Pull Request Guidelines