feat(react): add enabled prop to useAgent hook for conditional connections#798
Closed
Suhaib3100 wants to merge 1 commit intocloudflare:mainfrom
Closed
feat(react): add enabled prop to useAgent hook for conditional connections#798Suhaib3100 wants to merge 1 commit intocloudflare:mainfrom
Suhaib3100 wants to merge 1 commit intocloudflare:mainfrom
Conversation
…ections This adds an `enabled` optional prop to `useAgent` that allows conditionally connecting to an Agent. When `enabled` is `false`, the connection will not be established. When it transitions from `false` to `true`, the connection is established via reconnect(). When it transitions from `true` to `false`, the connection is closed. Use cases: - Auth-based conditional connections (only connect when authenticated) - Feature flag based connections - Lazy loading patterns (defer connection until component is visible) Implementation: - Added `enabled?: boolean` to UseAgentOptions type with JSDoc documentation - Default value is `true` (maintains backward compatibility) - Uses `startClosed: !enabled` for initial connection state - Uses useEffect with prevEnabledRef to handle state transitions Closes cloudflare#533
🦋 Changeset detectedLatest commit: 6c09b80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
|
fixed in cloudflare/partykit#315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
enabledprop to theuseAgenthook, allowing for conditional agent connections. This is a feature that was requested in issue #533.Problem
Currently, when using
useAgent, the connection is always established immediately when the hook is called. This makes it difficult to implement patterns like:Solution
Added an
enabledoptional boolean prop toUseAgentOptionsthat controls whether the agent connection should be established.Implementation Details
enabled?: booleantoUseAgentOptionswith JSDoc documentation explaining the behaviorenableddefaults totrueto maintain backward compatibilitystartClosed: !enabledto control the initial connection state via PartySocketuseEffectwith aprevEnabledRefto handle dynamic changes:enabledtransitions fromfalsetotrue: callsagent.reconnect()enabledtransitions fromtruetofalse: callsagent.close()Usage Example
Changes
packages/agents/src/react.tsx: Addedenabledprop toUseAgentOptionstype and implementation inuseAgenthookpackages/agents/src/react-tests/enabled-prop.test.ts: Added comprehensive test suite (14 tests) covering:Testing
All 14 new tests pass:
Checklist
true)Closes #533