fix: don't initialize telemetry when constructing a TestTelemetryContext#179
Merged
fisherdarling merged 2 commits intomainfrom Mar 11, 2026
Merged
fix: don't initialize telemetry when constructing a TestTelemetryContext#179fisherdarling merged 2 commits intomainfrom
fisherdarling merged 2 commits intomainfrom
Conversation
In #160 we added a panic/sentry hook to foundations. To test that the hook properly emits an error! log, we modified the `TestTelemetryContext` to also set the `TELMETRY_INITIALIZED` static, which the panic handler checks. However, this means that if a `TestTelemetryContext` is created, and then `telemetry::init` is executed, the call init call, will fail since `telemtry::init` expects to only be called once per-process. This caused a breakage in an internal app. To fix this, `TestTelemetryContext` no longer sets the `TELEMETRY_INITIALIZED` boolean and we simply call init ourselves in the test.
TheJokr
approved these changes
Mar 11, 2026
fisherdarling
force-pushed
the
fisher/init-fix
branch
from
896302e to
3e9f9b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #160 we added a panic/sentry hook to foundations. To test that the hook properly emits an error! log, we modified the
TestTelemetryContextto also set theTELMETRY_INITIALIZEDstatic, which the panic handler checks. However, this means that if aTestTelemetryContextis created, and thentelemetry::initis executed, the call init call, will fail sincetelemtry::initexpects to only be called once per-process. This caused a breakage in an internal app.To fix this,
TestTelemetryContextno longer sets theTELEMETRY_INITIALIZEDboolean and we simply call init ourselves in the test.Also includes a release commit for 5.5.3