Skip to content

feat(chart): Create sankey chart#128

Merged
mattrothenberg merged 1 commit intocloudflare:mainfrom
BrendanDavies:sankey
May 7, 2026
Merged

feat(chart): Create sankey chart#128
mattrothenberg merged 1 commit intocloudflare:mainfrom
BrendanDavies:sankey

Conversation

@BrendanDavies
Copy link
Copy Markdown
Contributor

@BrendanDavies BrendanDavies commented Feb 20, 2026

Fixes [SHIP-10714]

Adds a new SankeyChart component for visualizing flow/relationship data between nodes.

Changes

  • New SankeyChart component with ECharts integration
  • Support for custom colors, tooltips, click handlers, and drill-down
  • XSS protection via HTML escaping and color sanitization
  • Dark mode support
  • Comprehensive test suite (26 tests)
  • Demo page with 8 example implementations

  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: Bonk keeps timing out on reviewing the new components
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

@BrendanDavies BrendanDavies changed the title feat: Create sankey chart feat(chart): Create sankey chart Mar 12, 2026
@BrendanDavies BrendanDavies marked this pull request as ready for review March 12, 2026 20:02
@stritt
Copy link
Copy Markdown
Collaborator

stritt commented Mar 17, 2026

@BrendanDavies can you resolve conflicts here so we can test?

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 20, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@128

commit: 927631e

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2026

Docs Preview

View docs preview

Commit: 927631e

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2026

Visual Regression Report — 2 changed, 0 unchanged

2 screenshot(s) with visual changes:

Dialog (Open)

18,562,578 px (92.38%) changed

Before After Diff
Before After Diff

Select (Open)

23,156,359 px (93.49%) changed

Before After Diff
Before After Diff

Generated by Kumo Visual Regression

@stritt
Copy link
Copy Markdown
Collaborator

stritt commented Apr 8, 2026

/bonk review code

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 8, 2026

@stritt Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@BrendanDavies
Copy link
Copy Markdown
Contributor Author

/bonk review code

Comment thread packages/kumo/src/components/chart/SankeyChart.tsx Outdated
Comment thread packages/kumo/src/components/chart/SankeyChart.tsx Outdated
Comment thread packages/kumo/src/components/chart/SankeyChart.tsx Outdated
Comment thread packages/kumo-docs-astro/src/pages/charts/sankey.astro
@BrendanDavies BrendanDavies force-pushed the sankey branch 3 times, most recently from 8158850 to 09b195b Compare April 17, 2026 17:42
@BrendanDavies BrendanDavies force-pushed the sankey branch 2 times, most recently from 9b87dbe to 6171628 Compare May 6, 2026 16:56
@BrendanDavies BrendanDavies requested a review from invisal May 6, 2026 17:11
@BrendanDavies
Copy link
Copy Markdown
Contributor Author

/bonk review code

@BrendanDavies BrendanDavies force-pushed the sankey branch 2 times, most recently from 3d56758 to a174da6 Compare May 6, 2026 18:28
@mattrothenberg
Copy link
Copy Markdown
Collaborator

/bonk review please

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 6, 2026

@mattrothenberg Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@BrendanDavies BrendanDavies force-pushed the sankey branch 2 times, most recently from 97ab676 to 2eb6531 Compare May 6, 2026 20:36
@mattrothenberg mattrothenberg merged commit 8a33813 into cloudflare:main May 7, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants