Skip to content

agents: update AGENTS#494

Closed
rozenmd wants to merge 2 commits intomainfrom
rozenmd/screenshot-worker-refactor-pt8
Closed

agents: update AGENTS#494
rozenmd wants to merge 2 commits intomainfrom
rozenmd/screenshot-worker-refactor-pt8

Conversation

@rozenmd
Copy link
Copy Markdown
Collaborator

@rozenmd rozenmd commented May 6, 2026

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Reviews
    • bonk has reviewed the change
    • automated review not possible because:
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

@rozenmd
Copy link
Copy Markdown
Collaborator Author

rozenmd commented May 6, 2026

/bonk can you review this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 6, 2026

Review for PR #494

This is a great refactoring of the CI documentation! The changes break down the monolithic ci/AGENTS.md into focused, subdirectory-specific AGENTS.md files. This aligns perfectly with the pattern described in the root AGENTS.md.

What I like:

  1. Logical decomposition - Each subdirectory now has its own AGENTS.md with relevant details:

    • reporters/ - Artifact bus contract and conventions
    • scripts/ - Executable entrypoints and changeset validation rules
    • utils/ - Shared helpers for git/GitHub/PR operations
    • versioning/ - Shell orchestration with clear human-only rules
    • visual-regression/ - Complete VR system documentation
  2. Consistent structure - All new files follow the established AGENTS.md format (WHERE TO LOOK tables, CONVENTIONS, ANTI-PATTERNS, NOTES)

  3. Good cross-references - The root ci/AGENTS.md now serves as a proper index pointing to subdirectory docs

  4. Security consciousness - The versioning AGENTS.md correctly documents the human-only rules for production releases and the anti-pattern of running fork code with secrets

  5. VR documentation - The visual-regression AGENTS.md is particularly thorough, documenting the worker contract, change classification, and fork safety

Suggestions:

None - this is a straightforward documentation refactor that improves maintainability. The information is preserved and better organized.

LGTM! 🚀

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@494

commit: e1813b2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Docs Preview

View docs preview

Commit: 93fcf13

@rozenmd rozenmd closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant