Skip to content

fix(select): replace Field label with Select.Label from Base UI#500

Closed
najlaskr wants to merge 2 commits intocloudflare:mainfrom
najlaskr:najla/select-api
Closed

fix(select): replace Field label with Select.Label from Base UI#500
najlaskr wants to merge 2 commits intocloudflare:mainfrom
najlaskr:najla/select-api

Conversation

@najlaskr
Copy link
Copy Markdown
Contributor

@najlaskr najlaskr commented May 8, 2026

Updates Select label API to use Base UI's Select.Label for better accessibility and hover coupling issues.

  • Switch Select over to Base UI’s Select.Label so the trigger gets its accessible name without relying on a native <label>—fixes the hover coupling bug and silences the dev warning while preserving tooltips/optional badges via our Label component.
  • Inline the Field wrapper behavior (error normalization, helper text toggling, aria-describedby wiring) so the label, description, and error props keep working exactly as before.
  • Allow Label to accept an id, and document the updated compound pieces (Select.Label, Select.Group, Select.GroupLabel, Select.Separator) so manual composition stays clear.

  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: no access to bonk
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows: ran pnpm checks locally
    • Additional testing not necessary because:

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 8, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@500

commit: 527bcb0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Docs Preview

View docs preview

Commit: 527bcb0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Visual Regression Report — 17 changed, 21 unchanged

17 screenshot(s) with visual changes:

Button / Variant: Primary

166 px (0.16%) changed

Before After Diff
Before After Diff

Button / Loading State

3 px (0%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

259 px (0.26%) changed

Before After Diff
Before After Diff

Dialog / Dialog Confirmation

352 px (0.35%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

244 px (0.24%) changed

Before After Diff
Before After Diff

Select / Select Without Label

105 px (0.1%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

595 px (0.59%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

501 px (0.49%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Loading

2,072 px (1.03%) changed

Before After Diff
Before After Diff

Select / Select Multiple

556 px (0.55%) changed

Before After Diff
Before After Diff

Select / Select Complex

1,090 px (0.92%) changed

Before After Diff
Before After Diff

Select / Select Disabled Items

231 px (0.23%) changed

Before After Diff
Before After Diff

Select / Select Grouped

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

450 px (0.44%) changed

Before After Diff
Before After Diff

Select / Select Long List

1,572 px (1.33%) changed

Before After Diff
Before After Diff

Select (Open)

392,818 px (1.58%) changed

Before After Diff
Before After Diff
21 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Button / Title
  • Button / Link as Button
  • Dialog / Dialog Basic
  • Dialog / Dialog Alert
  • Dialog / Dialog With Combobox
  • Dialog / Dialog With Dropdown
  • Dialog (Open)
  • Select / Select Basic
  • Select / Select Sizes
  • Select / Select With Field
  • Select / Select Disabled Options

Generated by Kumo Visual Regression

@mattrothenberg
Copy link
Copy Markdown
Collaborator

Superseded by #502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants