feat: Add enabled prop to useWebSocket hook for conditional connection control.#231
Closed
zxcodes wants to merge 2 commits intocloudflare:mainfrom
Closed
feat: Add enabled prop to useWebSocket hook for conditional connection control.#231zxcodes wants to merge 2 commits intocloudflare:mainfrom
zxcodes wants to merge 2 commits intocloudflare:mainfrom
Conversation
zxcodes
changed the title
Author
|
Hello! Just wanted to know if any blockers are preventing this from being merged! @threepointone @third774 |
Collaborator
|
fixed in #315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
enabledprop to theuseWebSockethook, allowing conditional WebSocket connection control. Whenenabledisfalse, the connection is not established. This prevents unnecessary socket connections and avoids violating the React rules of hooks, which don't allow calling hooks conditionally.