fix(partysocket): add React Native environment detection for dispatchEvent#294
Merged
threepointone merged 2 commits intocloudflare:mainfrom Jan 30, 2026
Merged
Conversation
…Event React Native/Expo environments have both `process` and `document` polyfilled, but not `process.versions.node`. This caused the library to incorrectly use browser-style event cloning, which produces events that fail `instanceof Event` checks in event-target-polyfill. This fix adds explicit React Native detection using the standard `navigator.product === "ReactNative"` check, and uses Node-style event cloning which creates proper Event instances. Fixes cloudflare#257
🦋 Changeset detectedLatest commit: f5851a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@threepointone really dont want to be annoying but this PR would be amazing for us React Native users! Thanks |
Collaborator
|
Ok promise I'll look at it this week |
Collaborator
|
this is very nice, thank you. |
threepointone
approved these changes
Jan 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #257
React Native/Expo users experience
TypeError: Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'when using partysocket.Root Cause
The environment detection logic incorrectly identifies React Native as a browser environment because:
processanddocumentpolyfilledprocess.versions.nodeisNode = false, selecting browser-style event cloninginstanceof Eventchecks inevent-target-polyfillSolution
Added explicit React Native environment detection using the standard
navigator.product === "ReactNative"check:Changes
packages/partysocket/src/ws.ts- Added React Native environment detectionpackages/partysocket/src/tests/react-native.test.ts- Added test coverageTest Plan