Make connection state/setState properties configurable and validate room/basePath on construction
#319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make connection property descriptors configurable by adding configurable: true to state, setState, serializeAttachment and deserializeAttachment so downstream consumers (e.g. Cloudflare Agents SDK) can redefine or namespace them. Update types and tests to cover redefinition and state round-trips (hibernating and in-memory paths), and add DurableObject test classes and wrangler entries. Add validation in PartySocket to throw a clear error when constructed without room or basePath (unless startClosed: true) to avoid silently connecting to malformed URLs. Misc: refactor/guard many partysocket tests with skipIf on CI and adjust error-handling and edge-case tests accordingly. Two changeset files record patch bumps for partyserver and partysocket.
🦋 Changeset detectedLatest commit: 5c7851c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Feb 8, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
partyserver: Addconfigurable: trueto thestate,setState,serializeAttachment, anddeserializeAttachmentproperty descriptors on connection objects. This allows downstream consumers (like the Cloudflare Agents SDK) to redefine these properties viaObject.definePropertyfor namespacing or wrapping internal state storage. Default behavior is unchanged.partysocket: Throw a clear error when constructing aPartySocketwithoutroomorbasePath(and withoutstartClosed: true), instead of silently connecting to a malformed URL containing"undefined"as the room name.Tests: Add tests for configurable property redefinition (both hibernating and non-hibernating paths),
setStateround-trip persistence, and the new constructor validation. Changedescribe.skip→describe.skipIf(!!process.env.GITHUB_ACTIONS)across partysocket tests so they run locally but remain skipped in CI. Fix port collision betweenreact-ssrandedge-casestest suites, and individually skip flaky WebSocket-connection-dependent hook tests.Test plan
GITHUB_ACTIONS=true): identical to previous behavior (45 partysocket + 12 partyserver pass)