Conversation
aron-cf
requested review from
ghostwriternr,
scuffi and
whoiskatrin
as code owners
🦋 Changeset detectedLatest commit: 80add91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/bonk fix the CI issues seen in https://github.com/cloudflare/sandbox-sdk/actions/runs/23158193751/job/67278717682?pr=500. bump wrangler everywhere. |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
CI is failing on the quality / lint-typecheck job. The sherif monorepo consistency checker reports that wrangler has multiple versions defined across the workspace:
⨯ error Dependency wrangler has multiple versions defined in the workspace. multiple-dependency-versions
./ ^4.74.0 ↑ highest
./examples
alpine ^4.70.0 ↓ lowest
authentication ^4.70.0 ↓ lowest
claude-code ^4.70.0 ↓ lowest
code-interpreter ^4.70.0 ↓ lowest
collaborative-terminal ^4.70.0 ↓ lowest
desktop ^4.70.0 ↓ lowest
minimal ^4.70.0 ↓ lowest
openai-agents ^4.70.0 ↓ lowest
opencode ^4.70.0 ↓ lowest
time-machine ^4.70.0 ↓ lowest
typescript-validator ^4.70.0 ↓ lowest
./packages
sandbox ^4.70.0 ↓ lowest
./sites
sandbox ^4.70.0 ↓ lowest
The root package.json was bumped to ^4.74.0, but the wrangler version in all the example projects, packages/sandbox, and sites/sandbox still references ^4.70.0. These all need to be updated to ^4.74.0 as well, and package-lock.json regenerated.
The ci/basic failure is a downstream consequence of the quality gate failing.
|
I've posted a review requesting changes on PR #500. The issue is straightforward: CI is failing because only the root |
|
/bonk fix the issues you identified |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Bumped wrangler from ^4.70.0 to ^4.74.0 in all 13 workspace packages that were missed in the original commit:
packages/sandboxsites/sandbox- All 11 examples (
alpine,authentication,claude-code,code-interpreter,collaborative-terminal,desktop,minimal,openai-agents,opencode,time-machine,typescript-validator)
sherif now passes with no version mismatch errors.
|
Done. Here's what was fixed: The CI failure was caused by Changes made:
Verification: |
commit: |
🐳 Docker Images Published
Usage: FROM cloudflare/sandbox:0.0.0-pr-500-80add91Version: 📦 Standalone BinaryFor arbitrary Dockerfiles: COPY --from=cloudflare/sandbox:0.0.0-pr-500-80add91 /container-server/sandbox /sandbox
ENTRYPOINT ["/sandbox"]Download via GitHub CLI: gh run download 23447428661 -n sandbox-binaryExtract from Docker: docker run --rm cloudflare/sandbox:0.0.0-pr-500-80add91 cat /container-server/sandbox > sandbox && chmod +x sandbox |
|
Bumped to 7.46.0 will merge after that |
3 participants
This brings things up-to-date with current releases. In addition we've been seeing some issues in local development with the introduction of the proxy-everything container sidecar so this will run the full test suite.