Merged
Conversation
sleepAfter was only held in memory, unlike keepAlive and containerTimeouts. After DO eviction the value reverted to the default and the config cache prevented re-sending it. Write to storage in setSleepAfter and restore during init.
ghostwriternr
requested review from
aron-cf,
scuffi and
whoiskatrin
as code owners
|
commit: |
Contributor
📦 Preview BuildVersion: Install the SDK preview:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
whoiskatrin
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sleepAfterwas the only configuration setter not persisted to Durable Object storage. After DO eviction it reverted to the class default while the isolate-local config cache ingetSandbox()prevented re-sending it, so the sandbox could silently run with the wrong sleep timeout.Persist in
setSleepAfter()and restore duringblockConcurrencyWhileinit, matchingkeepAliveandcontainerTimeouts.